-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic inequality mesasures: lorenz curve and gini #414
Conversation
Tests added, passed nosetests
Thanks @cdagnino For me, Since I can see your motivation for wrapping the functionality in a class, since you propose additional methods, but the cost of preserving these operations as individual functions is not high. |
thanks @cdagnino this is looking good. I agree with @jstac comment re In other code I often write |
@cdagnino Thanks for your help to date. Should we leave this to you or do you not have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdagnino This looks good. I just made a few comments that might help the documentation be a bit cleaner.
thanks @cdagnino and @rebekahanne -- look forward to merging this. |
@mmcky @rebekahanne I pushed the suggested changes to the docs. Let me know if anything else is missing :-D |
thanks @cdagnino and @rebekahanne. I have tagged this as ready and it will be merged later today. |
First stab at creating inequality indices, as discussed in #395
Tests added and
nosetests
passed.