Test failures with xtensor version 0.10.9+

[ghisvail]

See the Debian CI test logs for version 0.10.9 and version 0.10.10.

[==========] Running 32 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 15 tests from pyarray
[ RUN      ] pyarray.initializer_constructor
[       OK ] pyarray.initializer_constructor (0 ms)
[ RUN      ] pyarray.shaped_constructor
[       OK ] pyarray.shaped_constructor (0 ms)
[ RUN      ] pyarray.strided_constructor
[       OK ] pyarray.strided_constructor (0 ms)
[ RUN      ] pyarray.valued_constructor
[       OK ] pyarray.valued_constructor (0 ms)
[ RUN      ] pyarray.strided_valued_constructor
[       OK ] pyarray.strided_valued_constructor (0 ms)
[ RUN      ] pyarray.copy_semantic
[       OK ] pyarray.copy_semantic (0 ms)
[ RUN      ] pyarray.move_semantic
[       OK ] pyarray.move_semantic (0 ms)
[ RUN      ] pyarray.extended_constructor
[       OK ] pyarray.extended_constructor (0 ms)
[ RUN      ] pyarray.reshape
[       OK ] pyarray.reshape (0 ms)
[ RUN      ] pyarray.access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:321: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec(2, 1)
      Which is: 9
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:316: row_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:332: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec(2, 1)
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:327: column_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:343: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec(2, 1)
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:338: central_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:354: Failure
      Expected: vec(2, 0, 0)
      Which is: 16
To be equal to: vec(2, 0)
      Which is: -1
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:349: unit_shape access
[  FAILED  ] pyarray.access (0 ms)
[ RUN      ] pyarray.indexed_access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:390: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec[index1]
      Which is: 9
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:385: row_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:400: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec[index1]
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:395: column_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:410: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec[index1]
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:405: central_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:422: Failure
      Expected: vec(2, 0, 0)
      Which is: 16
To be equal to: vec[id1]
      Which is: -1
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:415: unit_shape access
[  FAILED  ] pyarray.indexed_access (0 ms)
[ RUN      ] pyarray.broadcast_shape
[       OK ] pyarray.broadcast_shape (0 ms)
[ RUN      ] pyarray.iterator
[       OK ] pyarray.iterator (0 ms)
[ RUN      ] pyarray.initializer_list
[       OK ] pyarray.initializer_list (0 ms)
[ RUN      ] pyarray.zerod
[       OK ] pyarray.zerod (0 ms)
[----------] 15 tests from pyarray (0 ms total)

[----------] 14 tests from pytensor
[ RUN      ] pytensor.initializer_constructor
[       OK ] pytensor.initializer_constructor (0 ms)
[ RUN      ] pytensor.shaped_constructor
[       OK ] pytensor.shaped_constructor (0 ms)
[ RUN      ] pytensor.strided_constructor
[       OK ] pytensor.strided_constructor (0 ms)
[ RUN      ] pytensor.valued_constructor
[       OK ] pytensor.valued_constructor (0 ms)
[ RUN      ] pytensor.strided_valued_constructor
[       OK ] pytensor.strided_valued_constructor (0 ms)
[ RUN      ] pytensor.copy_semantic
[       OK ] pytensor.copy_semantic (0 ms)
[ RUN      ] pytensor.move_semantic
[       OK ] pytensor.move_semantic (0 ms)
[ RUN      ] pytensor.extended_constructor
[       OK ] pytensor.extended_constructor (0 ms)
[ RUN      ] pytensor.reshape
[       OK ] pytensor.reshape (0 ms)
[ RUN      ] pytensor.access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:321: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec(2, 1)
      Which is: 9
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:316: row_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:332: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec(2, 1)
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:327: column_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:343: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec(2, 1)
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:338: central_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:354: Failure
      Expected: vec(2, 0, 0)
      Which is: 16
To be equal to: vec(2, 0)
      Which is: -1
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:349: unit_shape access
[  FAILED  ] pytensor.access (0 ms)
[ RUN      ] pytensor.indexed_access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:390: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec[index1]
      Which is: 9
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:385: row_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:400: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec[index1]
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:395: column_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:410: Failure
      Expected: vec(2, 1, 0)
      Which is: 20
To be equal to: vec[index1]
      Which is: 2
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:405: central_major access
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:422: Failure
      Expected: vec(2, 0, 0)
      Which is: 16
To be equal to: vec[id1]
      Which is: -1
Google Test trace:
/tmp/autopkgtest-virt-lxc.shared.v25qf1sr/downtmp/autopkgtest_tmp/test_common.hpp:415: unit_shape access
[  FAILED  ] pytensor.indexed_access (1 ms)
[ RUN      ] pytensor.broadcast_shape
[       OK ] pytensor.broadcast_shape (0 ms)
[ RUN      ] pytensor.iterator
[       OK ] pytensor.iterator (0 ms)
[ RUN      ] pytensor.zerod
[       OK ] pytensor.zerod (0 ms)
[----------] 14 tests from pytensor (1 ms total)

[----------] 3 tests from pyvectorize
[ RUN      ] pyvectorize.function
[       OK ] pyvectorize.function (0 ms)
[ RUN      ] pyvectorize.lambda
[       OK ] pyvectorize.lambda (0 ms)
[ RUN      ] pyvectorize.complex
[       OK ] pyvectorize.complex (0 ms)
[----------] 3 tests from pyvectorize (0 ms total)

[----------] Global test environment tear-down
[==========] 32 tests from 3 test cases ran. (1 ms total)
[  PASSED  ] 28 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] pyarray.access
[  FAILED  ] pyarray.indexed_access
[  FAILED  ] pytensor.access
[  FAILED  ] pytensor.indexed_access

 4 FAILED TESTS

[SylvainCorlay]

Thanks for reporting this @ghisvail. This fell through the cracks in our CI because of the way we were selecting the version of xtensor in the CI.

If you are interested in what is going on, the behavior of the element access methods (operator() and element) is undefined when the number of passed indices is strictly lower than the dimension, as per the documentation:

 Returns a reference to the element at the specified position in the container.
 @param args a list of indices specifying the position in the container. Indices
 must be unsigned integers, the number of indices should be equal or greater than
 the number of dimensions of the container.

Before 0.10.9, the actual behavior that we were actually testing was to have operator() and element() behave as if the we appended zeros to the list of indices to match the dimension. Although we were not documenting this.

As of 0.10.9 we changed that behavior, to be such that operator() and element() behave as if the we preprended zeros to the list of indices to match the dimension.

The reason why we made that change is that we want to define it so that we have

(a + b)(indices..) = a(indices...) + b(indices...)

in all cases, even when broadcasting of dimensions occurs.