Improved support for Windows, updates to dataset.meta_to_json() #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests have all passed, let me pull this locally and test some spss reading on the mac and if that all works then I'll merge - hopefully before the weekend. |
|
hi guys, thanks for the updates on the savReaderWriter issues with Windows systems, took me hours to debug, but after the tweaks to header.py and generic.py it works on win 10. Can you please merge Matt's revisions? thanks again |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError: LoadLibrary() argument 1 must be str, not Nonewhen usingread_spss()andwrite_spss()on Windows. Force msvcrt as libc ifos.name == 'nt'.TypeError: Object of type int64 is not JSON serializablewhen usingdataset.meta_to_json(). Integers were being stored as numpy data type. Solution from https://stackoverflow.com/a/57915246.AttributeError: 'str' object has no attribute 'json'when usingdataset.meta_to_json(). When setting the jsonpath,''.json()should be''.join().