Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up schemas #2024

Merged
merged 6 commits into from
Apr 21, 2024
Merged

Clean up schemas #2024

merged 6 commits into from
Apr 21, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Apr 21, 2024 •
edited
Loading

Summary of Changes

Internal refactoring of schemas to prevent code duplication.

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) April 21, 2024 05:14
@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) April 21, 2024 05:15
@Andrew-S-Rosen Andrew-S-Rosen merged commit 54a897e into main Apr 21, 2024
17 of 18 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the schema_cleanup branch April 21, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Andrew-S-Rosen