Fix multithreading issues with settings management #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cc into concurrency_fix
…cc into concurrency_fix
…cc into concurrency_fix
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
+ Coverage 99.02% 99.03% +0.01%
==========================================
Files 82 82
Lines 3387 3431 +44
==========================================
+ Hits 3354 3398 +44
Misses 33 33 ☔ View full report in Codecov by Sentry. |
Andrew-S-Rosen
changed the title
Andrew-S-Rosen
added a commit
that referenced
this pull request
Jun 20, 2024
…low engine (v2) (#2277) This PR is a collaboration with @honghuikim. It is a continuation of #2163 that addresses changes introduced in #2276. For additional history on this PR, please refer to #2163. The focus of this PR is to enable dynamic changing of Pydantic model settings when using an active workflow engine. This is achieved, in large part, through a new `settings_swap` keyword argument to the decorator. Closes #2147. --------- Co-authored-by: Honghui Kim <itab1107@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Honghui Kim <165984476+honghuikim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2275.