Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate custom types to types.py #2317

Merged
merged 21 commits into from
Jul 1, 2024
Merged

Migrate custom types to types.py #2317

merged 21 commits into from
Jul 1, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Jul 1, 2024

Summary of Changes

Finalize movement of custom types to types.py.

FYI: @AitElBadaoui.

Requirements

Notes

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (d227f84) to head (de499e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   99.07%   99.06%   -0.02%     
==========================================
  Files          85       85              
  Lines        3561     3517      -44     
==========================================
- Hits         3528     3484      -44     
  Misses         33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) July 1, 2024 15:35
@Andrew-S-Rosen Andrew-S-Rosen merged commit 7d4de2b into main Jul 1, 2024
21 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the types2 branch July 1, 2024 15:43
@AitElBadaoui
Copy link
Contributor

@Andrew-S-Rosen Great work! Thank you for taking the suggestion into account!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants