Changed expect_g and fidelity_g to return the "correctly" scaled gradient w.r.t to the register #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some tests are still broken
Codecov ReportBase: 88.28% // Head: 86.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 88.28% 86.93% -1.36%
==========================================
Files 76 16 -60
Lines 4765 1408 -3357
==========================================
- Hits 4207 1224 -2983
+ Misses 558 184 -374 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
need tests pass before a review |
GiggleLiu
approved these changes
Dec 7, 2022
|
The tests fun on my local machines on julia 1.8.3 and 1.8.2 and are in parts of the tests that shouldn't be affected by my changes at all. So I also think that the failures on nightly are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now
expect_gandfidelity_gwere off by a factor of one half, in the sense that∂_reg expect(ham, reg) = 2 * expect_g(ham, reg) instead ∂_reg expect(ham, reg) = expect_g(ham, reg) and analogous for the other methods of
expect_gandfidelity_g. This was counter acted by multiplying a factor of 2 to the finalparamsδat the end ofexpect_g(ham, reg => circuit)andfidelity_g(reg1 => circuit1, reg2 => circuit2).This is changed here to backpropagate the "correctly" scaled gradient w.r.t registers.
I am not sure if this would be considered a breaking change, because it also means that the output of
expect'(ham, reg => circuit)[1]is changed by a factor of 2 now.Changes: