Added docstring to pauli_error_channel()
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and changed meaning of `p` in `bit_flip_channel` and `phase_flip_channel` to be consistent with the other error channels Changes to be committed: modified: lib/YaoBlocks/src/channel/error_channel.jl modified: lib/YaoBlocks/test/channel/error_channel.jl
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 88.24% 88.76% +0.52%
==========================================
Files 77 51 -26
Lines 4807 3134 -1673
==========================================
- Hits 4242 2782 -1460
+ Misses 565 352 -213 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Roger-luo
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and changed meaning of
pinbit_flip_channelandphase_flip_channelto be consistent with the other error channelsChanges to be committed:
modified: lib/YaoBlocks/src/channel/error_channel.jl
modified: lib/YaoBlocks/test/channel/error_channel.jl