Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some type parameters that caused warnings in precompilation #470

Merged
merged 1 commit into from
May 15, 2023
Merged

Removed some type parameters that caused warnings in precompilation #470

merged 1 commit into from
May 15, 2023

Conversation

jlbosse
Copy link
Contributor

@jlbosse jlbosse commented May 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (c60f6d9) 88.28% compared to head (ecb724f) 88.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   88.28%   88.27%   -0.02%     
==========================================
  Files          77       32      -45     
  Lines        4824     1748    -3076     
==========================================
- Hits         4259     1543    -2716     
+ Misses        565      205     -360     
Impacted Files Coverage Δ
lib/YaoSym/src/symengine/instruct.jl 71.42% <ø> (ø)

... and 60 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@GiggleLiu GiggleLiu merged commit 6460fc5 into QuantumBFS:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants