-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues (IR, layout, Rule{:id}) #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 93.76% 93.25% -0.52%
==========================================
Files 11 11
Lines 1749 1927 +178
==========================================
+ Hits 1640 1797 +157
- Misses 109 130 +21
Continue to review full report at Codecov.
|
Roger-luo
reviewed
Oct 26, 2021
Co-authored-by: Rogerluo <rogerluo.rl18@gmail.com>
Roger-luo
reviewed
Oct 26, 2021
Roger-luo
reviewed
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full_reduction
will create IRs that cannot be converted toZXDiagram
s.generate_layout
more general.Rule{:id}
capable with inner Z-spiders (fix id rule for inner spiders for ZXGraph #78 ).