Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues (IR, layout, Rule{:id}) #86

Merged
merged 11 commits into from
Oct 27, 2021
Merged

Fix issues (IR, layout, Rule{:id}) #86

merged 11 commits into from
Oct 27, 2021

Conversation

ChenZhao44
Copy link
Member

@ChenZhao44 ChenZhao44 commented Sep 23, 2021

  1. Fix the case that full_reduction will create IRs that cannot be converted to ZXDiagrams.
  2. Makes generate_layout more general.
  3. Makes Rule{:id} capable with inner Z-spiders (fix id rule for inner spiders for ZXGraph #78 ).

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #86 (1d91bac) into master (46532b1) will decrease coverage by 0.51%.
The diff coverage is 70.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   93.76%   93.25%   -0.52%     
==========================================
  Files          11       11              
  Lines        1749     1927     +178     
==========================================
+ Hits         1640     1797     +157     
- Misses        109      130      +21     
Impacted Files Coverage Δ
src/rules.jl 91.60% <45.65%> (-3.01%) ⬇️
src/zx_graph.jl 93.60% <92.85%> (-1.61%) ⬇️
src/ir.jl 89.24% <100.00%> (+1.24%) ⬆️
src/simplify.jl 94.66% <100.00%> (+7.06%) ⬆️
src/zx_diagram.jl 96.78% <100.00%> (-0.06%) ⬇️
src/scalar.jl 100.00% <0.00%> (ø)
src/phase_teleportation.jl 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46532b1...1d91bac. Read the comment docs.

@ChenZhao44 ChenZhao44 changed the title Fix issues using IR Fix issues (IR, layout, Rule{:id}) Sep 26, 2021
src/simplify.jl Outdated Show resolved Hide resolved
Co-authored-by: Rogerluo <rogerluo.rl18@gmail.com>
@Roger-luo Roger-luo merged commit 4ba4035 into master Oct 27, 2021
@Roger-luo Roger-luo deleted the chen/fix-ir branch October 27, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

id rule for inner spiders for ZXGraph
2 participants