-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation #22
Conversation
I think most parts of the code should be documented now (up to less relevant, internal functions). What is left to be done is add a proper README and maybe document the examples with some explanations. |
Do you want to wait with the README or go ahead and do it right away? I am very much okay with already adding these docstrings, it's not that much work to change them afterwards if need be. |
I think we can add the README also later. But I will add some comments to the examples tomorrow morning. Then this PR should be ready to merge! I hope this will avoid most merge conflicts. |
This should be ready to review now. I haven't yet added any comments for the test scripts in PEPSKit.jl/examples/ since they will be converted to proper tests anyway at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go for me!
Co-authored-by: Lukas <37111893+lkdvos@users.noreply.github.com>
Co-authored-by: Lukas <37111893+lkdvos@users.noreply.github.com>
This PR will document all relevant functions and types, and provide a proper README.