Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #22

Merged
merged 8 commits into from
May 2, 2024
Merged

Add documentation #22

merged 8 commits into from
May 2, 2024

Conversation

pbrehmer
Copy link
Collaborator

This PR will document all relevant functions and types, and provide a proper README.

@pbrehmer pbrehmer marked this pull request as draft April 23, 2024 15:48
@pbrehmer
Copy link
Collaborator Author

pbrehmer commented May 1, 2024

I think most parts of the code should be documented now (up to less relevant, internal functions). What is left to be done is add a proper README and maybe document the examples with some explanations.

@lkdvos
Copy link
Member

lkdvos commented May 1, 2024

Do you want to wait with the README or go ahead and do it right away? I am very much okay with already adding these docstrings, it's not that much work to change them afterwards if need be.
I also still want to make some minor changes and clean up some of the files/folders, so it's better to first merge this such that we don't get merge conflicts, as writing docstrings touches large parts of the codebase.
Will you mark it as non-draft whenever you feel like its ready? I'll try and review asap then (allthough at first glance looks great)

@pbrehmer
Copy link
Collaborator Author

pbrehmer commented May 1, 2024

I think we can add the README also later. But I will add some comments to the examples tomorrow morning. Then this PR should be ready to merge! I hope this will avoid most merge conflicts.

@pbrehmer pbrehmer marked this pull request as ready for review May 2, 2024 09:48
@pbrehmer
Copy link
Collaborator Author

pbrehmer commented May 2, 2024

This should be ready to review now. I haven't yet added any comments for the test scripts in PEPSKit.jl/examples/ since they will be converted to proper tests anyway at some point.

docs/make.jl Outdated Show resolved Hide resolved
lkdvos
lkdvos previously approved these changes May 2, 2024
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go for me!

src/algorithms/ctmrg.jl Outdated Show resolved Hide resolved
src/algorithms/ctmrg.jl Outdated Show resolved Hide resolved
src/PEPSKit.jl Outdated Show resolved Hide resolved
Co-authored-by: Lukas <37111893+lkdvos@users.noreply.github.com>
pbrehmer and others added 2 commits May 2, 2024 15:25
Co-authored-by: Lukas <37111893+lkdvos@users.noreply.github.com>
@pbrehmer pbrehmer merged commit 8dfe883 into master May 2, 2024
11 checks passed
@pbrehmer pbrehmer deleted the documentation branch May 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants