Update 1D advection equation to work for multiple u and flux
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) for flux to b_vector. This has to be changed for different cases.
- Documentation written. - Unit tests passing. - Throughly tested for both options of volume integral calculation for different values of c in both directions.
- Maxwell's equations solved analytically in examples/maxwells_equations/analytical_solution.ipynb and the solution is overlapping with the numerical solution at all t.
…ll into advection_1d_multiple_u
|
Changes Unknown when pulling d796786 on amanabt:advection_1d_multiple_u into ** on QuazarTech:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till commit 28bbf6b in master the 1D advection solver only allows us to evolve 1 advection at a time. This PR will allow it to solve multiple equations simultaneously.
Some of the new
jupyter notebooksrelated to 1D Maxwell's equations might not work because theyneed the
flux_xfunction to be changed.