Trigger builds/uploads on github actions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change. QubesOS/qubes-issues#2573
No functional change. QubesOS/qubes-issues#2573
Comments in affected issues are only about 'stable' and 'testing' uploads (which makes sense). But tracking packages in issues dedicated for package tracking should be more detailed - which include 'security-testing' uploads. QubesOS/qubes-issues#2573
1. Trigger build process when appropriately signed version tag is pushed. 2. Trigger moving packages from testing to stable when appropriately signed comment is created in an issue (in theory, any issue, but in practice it's most convenient to comment in issues tracking particular package). Fixes QubesOS/qubes-issues#2573
This will avoid confusion about handling '$' and other shell special characters. Pass needed variables using -v to awk. Suggested by @woju QubesOS/qubes-issues#2573
In theory white characters will be rejected anyway a moment later - while checking for directory existence. But to be on a safe side, make it explicit earlier. Suggested by @woju QubesOS/qubes-issues#2573
Have it besides other context-less checks. Suggested by @woju QubesOS/qubes-issues#2573
Shell command 'echo' may consume some parameters, for example '-e' or '-n'. While it shouldn't happen here right now, make sure it will not hurt anyway. Suggested by @woju QubesOS/qubes-issues#2573
Verify also this part of command specification. QubesOS/qubes-issues#2573
|
Applied changes suggested by @woju |
jpouellet
reviewed
Feb 24, 2017
| comment_body = obj['comment']['body'] | ||
| # skip comment not having signed part at all | ||
| if '-----BEGIN PGP SIGNED MESSAGE-----' not in comment_body: | ||
| return |
There was a problem hiding this comment.
(yes yes... i see the verification down in qubesbuilder.ProcessGithubCommand)
There was a problem hiding this comment.
It was really tempting to put this xkcd in a comment here ;)
Wrap actual code under "if __name__ == '__main__'". Also fix print syntax. This allows having one dispatcher script calling appropriate function, instead of starting new process each time. QubesOS/qubes-issues#2573
qubesbuilder.TriggerBuild do not allow '/' in input argument. Better strip repository owner name in hook script, than weaken check in qrexec service running in build VM. In case of ambiguity, some builder instances will notice that nothing new is there to build. QubesOS/qubes-issues#2573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
Depends on QubesOS/qubes-builder#15