Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not activate unused LVM volumes #382

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Do not activate unused LVM volumes #382

wants to merge 2 commits into from

Commits on Jan 14, 2021

  1. tests: fix cleanup after failed test run 

    'set -e' prevented the cleanup to be called. Register cleanup with
'trap' instead.

Fixes: 76cd08a "Fix test suite"
    @marmarek
    marmarek committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    006e7a9 View commit details
    Browse the repository at this point in the history

  2. storage/lvm: do not activate unused LVM volumes 

    This prevents udev from accessing not currently used volumes, and also
makes LVM snapshot operations faster (less locking to do).

There is at least one unsolved problem here: inactive volumes do not
have size listed on `lvs` output. There is a band-aid by caching the
usage from the last time the volume was active, but it isn't enough for
many cases (at the very least - reporting disk usage of a VM that wasn't
started recently).

There may be also other places that assume existing volumes always have
relevant /dev/ node present.

Fixes QubesOS/qubes-issues#6184
    @marmarek
    marmarek committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    1c7364e View commit details
    Browse the repository at this point in the history