Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug 147, cmake support message #2

Closed
wants to merge 3 commits into from
Closed

fix bug 147, cmake support message #2

wants to merge 3 commits into from

Conversation

yodalee
Copy link
Contributor

@yodalee yodalee commented May 5, 2014

There are two modification.
First is bug 147:
I found that the base problem is that qucs/schematic.cpp pass float argument by a division of two integer, and doesn't add (float) casting.
After adding casting, the resize ratio will not be zero anymore.
Consider cpp style, maybe modify to static_cast is recommended.

Second is cmake supported
Since I cannot compile qucs/qucs on archlinux by autoconf/configure/make, I use cmake to compile the project.
I add some recommended message in README.md and ignore the recommended build path in .gitignore

The last one is ignore vim temporary file .*.swp file

@yodalee
Copy link
Contributor Author

yodalee commented May 5, 2014

The printed pdf is not in a good format, I will try to hack on that too.

@guitorri
Copy link
Member

guitorri commented May 7, 2014

I suggest you do your work on branches this way you will not mess with master.
Please try to make a separate PR for each bug or feature. It makes it easier to discuss and faster to merge.
Also note that the Readme is in markdown format, you might want break a line so the commands are rendered in a code block.

I recall you asked about the Qt warning messages. If I run qucs from the terminal/console, the warnings and debug messages should be printed in there.
Note that despite being quite complete, CMake support is still experimental.

@yodalee
Copy link
Contributor Author

yodalee commented May 7, 2014

Well, I compile successfully with CMake, and failed by automake tool T_T.
I run into qt issue / c++ namespace when configure qucs, qucs-core, respectively.


I will try to create branch to separate fix patch later.

@yodalee yodalee closed this May 7, 2014
@yodalee
Copy link
Contributor Author

yodalee commented May 7, 2014

I will make another PR with branch on each fix. Sorry for whole the mess.

@yodalee yodalee reopened this May 7, 2014
@yodalee yodalee closed this May 7, 2014
in3otd referenced this pull request in in3otd/qucs Apr 11, 2015
Corrected MUTX component behavior when changing number of coils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants