Power combining (develop) #509

andresmmera · 2016-04-25T19:48:39Z

Hello there,

This PR is aimed to replace PR #346 .

In addition to the existing features, it was added the LC equivalent of the Wilkinson power combiner (both single-stage and multistage).

On the other hand, it was added a panel on the right side of the window so as to display a preview of the current topology.

in3otd · 2017-04-22T11:18:04Z

nice work! I'm doing some testing, here are some random comments:

general:
- do not disable window resizing, someone somewhere on some platform will need to resize it. I saw the comments in the related commit but, still, what's the advantage for the user in disabling resize? Can the aspect ratio of the SVG images be fixed ? (I seem to remember a similar problem with the Active Filter tool images)
- disable "number of outputs" (visible but not active) for configurations when only 2 outputs are supported
- S-parameter simulation start/stop frequencies are wrong when the frequency units selected are not GHz. Or also when entering numbers < 1 in the frequency box.
- bonus point: change length units for the lines to have always numbers between 1 and 999 (engineering notation). I guess is safe to use misc::num2str() for everything that needs to be human readable.
if you select Bagley and then Gysel the Number of outputs shows 3, 5 and 7 but Gysel here supports 2 outputs only
some Topologies generate the equation for S11_dB, some don't; I think it's better to have it always (maybe also for all the Snn terms)
Wilkinson Multistage
- Microstrip Implementation and Lumped Elements Implementation should probably be radio buttons even if the current implementation works fine
- with Microstrips: the first microstrip has no W or L shown
Tree
- line parameters are not shown (I guess it's a choice for space reasons, right?)
- microstrip implementation has something wrong, seems centered to half the design frequency

in3otd · 2017-04-22T13:20:52Z

also you should set the main window icon

setWindowIcon(QPixmap(":/images/bitmaps/big.qucs.xpm"));

see e.g. the QucsActiveFilter() constructor.

andresmmera · 2017-04-22T13:26:29Z

👍
Ok, I'm gonna take a look.
Many thanks @in3otd !!

andresmmera · 2017-04-25T18:18:55Z

I think I've almost fixed all the issues you pointed out. I'll probably push tomorrow.
Just a few comments:

do not disable window resizing, someone somewhere on some platform will need to resize it. I saw the comments in the related commit but, still, what's the advantage for the user in disabling resize? Can the aspect ratio of the SVG images be fixed ? (I seem to remember a similar problem with the Active Filter tool images)

Well, I did so because at some point I thought it would be good to hide the substrate panel when the corresponding QCheckbox was unchecked. Somehow, that forced me to fix the window size. Anyway, I ended doing the same stuff the Active Filter tool does (this)

(Tree wilkinson combiner) line parameters are not shown (I guess it's a choice for space reasons, right?)

Yes, of course. Otherwise, it becomes a mesh...

bonus point: change length units for the lines to have always numbers between 1 and 999 (engineering notation). I guess is safe to use misc::num2str() for everything that needs to be human readable.

Ok, done. The only inconvenient is some corner case. For example, at very high freqs the user may select 'mils' and the final result might be given in 'nm'... but I guess nobody is going to use this tool at 3 THz or so :-)

guitorri · 2017-10-06T12:25:56Z

The microstrip implementations do not have a corresponding .svg figure right?
Do you think is worth adding?

guitorri · 2017-10-06T12:51:24Z

The Travelling wave does not create the S11_dB Equation. (no big deal)

guitorri · 2017-10-06T12:58:46Z

For different number of outputs the figures are also not there. I guess we can leave it as is, doesn't make sense to create figures for all combinations. (Some day we will be able to use the schematic as a library so we can render the schematic templates and get a figure back...)

Let me know if you want to change something else.

andresmmera · 2017-10-06T14:43:45Z

The microstrip implementations do not have a corresponding .svg figure right?
Do you think is worth adding?

Honestly, I didn't really think about that. I just wanted to give a visual clue about the combiner structure. I can create the corresponding svg files for the microstrip implementation (hopefully) this weekend.

The Travelling wave does not create the S11_dB Equation.

My bad. Didn't notice that...

For different number of outputs the figures are also not there.

Yes, I did that because otherwise the schematic becomes a mesh when you select a big number of outputs. I know that the isolation between output ports (i.e., Sxy, x != y != 1, ) is an important figure, but I thought that it would be more convenient if the user adds the equation manually in case of he/she's interested on that.

Let me know if you want to change something else.

I'll add the S11 equation for the TW and tree combiners and then I'll add the figures for the microstrip.

andresmmera · 2017-10-07T09:42:32Z

I've just pushed two commits in order to address the issues you mentioned yesterday

andresmmera · 2017-10-07T11:11:05Z

I don't know why Travis fails... I rerun it just in case, but the error is still there.
It says:

 rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
rm -f cscope.out cscope.in.out cscope.po.out cscope.files
make[2]: Leaving directory `/home/travis/build/Qucs/qucs/qucs-0.0.19/_build'
rm -f config.status config.cache config.log configure.lineno config.status.lineno
rm -f Makefile
ERROR: files left in build directory after distclean:
./qucs/qucs/qucs_.cpp
make[1]: *** [distcleancheck] Error 1
make[1]: Leaving directory `/home/travis/build/Qucs/qucs/qucs-0.0.19/_build'
make: *** [distcheck] Error 1

Any guess?

felix-salfelder · 2017-10-07T11:14:38Z

i don't know what triggers this. 6e3420e seems to fix it

andresmmera · 2017-10-07T11:17:48Z

👍 Thanks

I'll wait until you merge that and then I'll rerun Travis again.

felix-salfelder · 2017-10-07T11:58:24Z

#722

andresmmera · 2017-10-07T13:47:12Z

Cool!
Thanks @felix-salfelder

This is a tool for automatically create power combiners. It includes some popular power combining structures as well as corporate combiners. In addition to the old branch (-> master) features, it was added the LC equivalent of a 2-way Wilkinson combiner (both single-stage and multistage). Moreover, it was included a new panel for diplaying the combiner topology.

* Removed unused #includes * Added some comment

Travis CI cannot find "qucspowercombiningtool.h" header, so this commit is another attempt to solve the problem

* The window resizing policy was set to 'fixed', however, its size is scaled beforehand taking into account the screen dimensions so as to ensure a nice appearance: QDesktopWidget dw; QRect screenSize = dw.availableGeometry(this); DefaultSize = QSize(screenSize.width() * 0.5, screenSize.height() * 0.6);//Hide substrate tab ExtendedSize = QSize(screenSize.width() * 0.8, screenSize.height() * 0.6);//Show substrate tab this->setFixedSize(DefaultSize); * It was added a rounding function so as to avoid having irrelevant decimals in the components parameters * Moreover, it was added a combobox to let the user to choose the length units (mm, um, mil,...)

In commits before, the output power ratio is given in n.u. In order to present a more meaningful parameters, the output power ratio is now expressed in dB

This commit fixes includes the following: i) The window is again resizable. Basically, the svg image is fixed according to what is done in qucs-activefilter ii) The combobox for selecting the number of outputs is unabled for those topologies that do not allow >2 branches iii) Fixed the fstart/fstop in the S parameter block iv) The length units are changed automatically in order to show numbers \in [1, 999.99] only v) The equations block now includes dB(S[n, n]) where n = 1:(Number of outputs) vi) It was added a groupbox with radiobuttons so as to let the user choose the implementation (ideal TL, microstrip or CLC (only Wilkinson)) vii) Fixed microstrip implementation in the tree combiner (the impedance of the output branches was wrong)

if the selected power combiner type does not support the lumped elements implementation

This commit also includes a slight rearrangement of code. Specifically, the code related to the image update was concentrated in one function, which is called by different radiobutton event handlers.

guitorri · 2017-10-09T18:04:04Z

I rebased it locally. History is getting messy.
Can I force push to your branch? Please enable "Allow edit from maintainers" on the rigth.

andresmmera · 2017-10-09T18:19:29Z

Feel free to do whatever you need.
The "Allow edit from maintainers" checkbox is already enabled

guitorri · 2017-10-09T18:30:37Z

Thank you. I was giving the wrong branch name for update...

andresmmera added this to the 0.0.20 milestone Apr 25, 2016

andresmmera added the new-feature label Apr 25, 2016

andresmmera mentioned this pull request Apr 25, 2016

Power combining #346

Closed

andresmmera force-pushed the PowerCombining-develop branch from ea6c809 to 81c4cc8 Compare August 31, 2016 12:32

ra3xdh mentioned this pull request Jan 29, 2017

Merge new RF devices and tools #651

Closed

11 tasks

andresmmera force-pushed the PowerCombining-develop branch from 81c5de5 to 847d0aa Compare July 29, 2017 14:40

guitorri self-assigned this Oct 6, 2017

andresmmera and others added 9 commits October 9, 2017 20:00

Merged .gitignore

22c52e8

Updated .gitignore

38b94f8

Removed unnecessary includes

b08fb6a

* Removed unused #includes * Added some comment

Updated cmake

11cc4a1

Updated Makefile.am

764378f

Travis CI cannot find "qucspowercombiningtool.h" header, so this commit is another attempt to solve the problem

Output power ratio in dB

33db277

In commits before, the output power ratio is given in n.u. In order to present a more meaningful parameters, the output power ratio is now expressed in dB

andresmmera and others added 5 commits October 9, 2017 20:00

Removing binary file included by error

58f7a8c

Reset Implementation radio button to default value

01bf97b

if the selected power combiner type does not support the lumped elements implementation

Added S11 equations in the TW and tree power combiners

97133f1

Added images for the microstrip implementation

6109b66

This commit also includes a slight rearrangement of code. Specifically, the code related to the image update was concentrated in one function, which is called by different radiobutton event handlers.

powercombining: add missing icon for macOS

2d3bb89

guitorri force-pushed the PowerCombining-develop branch from 9e001e2 to 2d3bb89 Compare October 9, 2017 18:29

guitorri merged commit 591835b into Qucs:develop Oct 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Power combining (develop) #509

Power combining (develop) #509

andresmmera commented Apr 25, 2016

in3otd commented Apr 22, 2017

in3otd commented Apr 22, 2017

andresmmera commented Apr 22, 2017

andresmmera commented Apr 25, 2017

guitorri commented Oct 6, 2017

guitorri commented Oct 6, 2017

guitorri commented Oct 6, 2017

andresmmera commented Oct 6, 2017 •

edited

Loading

andresmmera commented Oct 7, 2017

andresmmera commented Oct 7, 2017

felix-salfelder commented Oct 7, 2017

andresmmera commented Oct 7, 2017

felix-salfelder commented Oct 7, 2017

andresmmera commented Oct 7, 2017

guitorri commented Oct 9, 2017

andresmmera commented Oct 9, 2017

guitorri commented Oct 9, 2017

Power combining (develop) #509

Power combining (develop) #509

Conversation

andresmmera commented Apr 25, 2016

in3otd commented Apr 22, 2017

in3otd commented Apr 22, 2017

andresmmera commented Apr 22, 2017

andresmmera commented Apr 25, 2017

guitorri commented Oct 6, 2017

guitorri commented Oct 6, 2017

guitorri commented Oct 6, 2017

andresmmera commented Oct 6, 2017 • edited Loading

andresmmera commented Oct 7, 2017

andresmmera commented Oct 7, 2017

felix-salfelder commented Oct 7, 2017

andresmmera commented Oct 7, 2017

felix-salfelder commented Oct 7, 2017

andresmmera commented Oct 7, 2017

guitorri commented Oct 9, 2017

andresmmera commented Oct 9, 2017

guitorri commented Oct 9, 2017

andresmmera commented Oct 6, 2017 •

edited

Loading