Replaced QLineedit by QComboBox for frequency input (for phasor and AC temporal diagram dialogs) #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit it was replaced the QLineEdit for the frequency input at the diagram dialog of the phasor diagram by a QComboBox showing only the available frequencies. In order to do this, a function named 'LoadAvailableFreqs()' was added to diagramdialog constructor. The purpose of this function is to look for the content of the 'acfrequency' field the current dataset and returns that data as a QStringList which feeds the QComboBox. 'LoadAvailableFreqs()' is called at the constructor but also when the click() event of the 'ChooseData' combo is triggered.
8 tasks
|
Looking good. |
|
lol, no. I'm just doing that to prove myself I checked things. |
|
@andresmmera , yep, I also thought you should put those screencasts to Youtube 😁 |
|
Seriously? |
|
Actually, these diagrams are supposed to show results for multiple frequencies at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to replace the QLineEdit by a QComboBox as the frequency input widget at the dialog window in the phasor and AC temporal diagrams. This way, the QCombo shows only the available frequencies.
In order to do that, a function named 'LoadAvailableFreqs()' has been added to diagramdialog constructor. The purpose of this function is to explore the content of the 'acfrequency' field of the current dataset and, finally, it returns that data as a QStringList which is used to feed the QComboBox.
'LoadAvailableFreqs()' is called at the constructor but also when the click() event of the 'ChooseData' combo is triggered.
Screencast here