All tags should implement hashCode() #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 141
💛 - Coveralls |
Marcono1234
reviewed
Dec 9, 2018
| @@ -293,6 +289,13 @@ public boolean equals(Object other) { | |||
| return true; | |||
| } | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
| int keyHash = Objects.hash(getValue().keySet().toArray()); | |||
There was a problem hiding this comment.
Why do you create here and in other cases an array first?
There was a problem hiding this comment.
Objects.hash() takes a vararg of objects, meaning that passing in just the key set will calculate the hash code of just the key set. Passing it as an array ensures that it calculates the hash codes for each element individually. That means that two different instance of e.g. a CompoundTag containing the exact same keys with equal values will result in the same hash code.
See Unit Test
There was a problem hiding this comment.
Nevermind, you seem to have changed it already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all Tags override
equals(), they must also overridehashCode()correctly.See #15