Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name manifest attribute #32

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

jochembroekhoff
Copy link
Contributor

This PR adds the Automatic-Module-Name attribute to the manifest of the final jar.

The value of this attribute is used to name automatic modules from jars that don't support Jigsaw (yet).

Without this explicit automatic module name, the module name resolved to NBT, but net.querz.nbt seems more appropriate.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.724% when pulling 94ed6d3 on jochembroekhoff:add-automatic-module-name into ff5ccab on Querz:master.

@Querz Querz merged commit 3128f53 into Querz:master Jul 8, 2019
@jochembroekhoff jochembroekhoff deleted the add-automatic-module-name branch July 8, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants