Updates for 4.1.0 #342
Merged
Updates for 4.1.0 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoMethodError now seems to include "module" in the message. Side note, not sure if this is even useful to be testing for.
ukd1
commented
Mar 22, 2024
| @@ -135,7 +132,7 @@ def process(queue, job) | |||
| def call(job) | |||
| args = job[:args] | |||
| receiver_str, _, message = job[:method].rpartition('.') | |||
| receiver = eval(receiver_str) | |||
| receiver = eval(receiver_str) # rubocop:disable Security/Eval | |||
There was a problem hiding this comment.
Skipped trying to fix this in this PR, moved to #351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.