[Do Not Merge] Compatibility updates for the latest swift-corelibs-xctest #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test cases will need to be `final` for now due to the `Self` reference on the new `allTests` type. Once codegen is available for `allTests` we can get rid of the `final` and the `XCTestCaseProvider` protocol altogether.
briancroom
force-pushed
the
update-allTests
branch
from
0bd445e
to
ef4b090
Compare
|
Hey @briancroom, I'm pretty sure this was part of some Swift releases. I'm assuming we need to still work on this to get Nimble updated on the latest swift releases? |
|
Hey @jeffh sorry for the slow follow up. Yes, this stuff will be needed, but the Swift 3 stdlib naming and importer changes also landed around the same time, so we will need to kick off a swift3 branch and of everything there together. I've started working a branch for this which I'm hoping to push tomorrow. I'd like to see #274 merged first though. |
1 task
|
Closing, these changes were merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since apple/swift-corelibs-xctest#40 was merged which contained breaking changes, we need to make some adjustments to remain compatible. This shouldn't be merged until the next Swift development snapshot is posted, though!
Also note that the XCTestCase subclasses here needing to be final is due to our XCTestCaseProvider protocol (no longer present in swift-corelibs-xctest!) which allows us to fail tests on OS X which are missing from allTests. This will be obsolete once SwiftPM gains support for codegen-ing allTests which is well on the way.