Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async/await #951

Closed
1 task done
tahirmt opened this issue Dec 9, 2021 · 4 comments
Closed
1 task done

Add support for async/await #951

tahirmt opened this issue Dec 9, 2021 · 4 comments

Comments

@tahirmt
Copy link

tahirmt commented Dec 9, 2021

  • I have read CONTRIBUTING and have done my best to follow them.

What did you do?

I think we should add support for swift Concurrency framework (async/await) especially now that it has been back deployed to iOS 13 and macOS 10.15.

Environment

List the software versions you're using:

  • Quick: 3.0.0
  • Nimble: 9.0.0
  • Xcode Version: 13.2 (13C90) (Open Xcode; In menubar: Xcode > About Xcode)
  • Swift Version: Xcode Default (Open Xcode Preferences; Components > Toolchains. If none, use Xcode Default.)

Please also mention which package manager you used and its version. Delete the
other package managers in this list:

  • Swift Package Manager 5.5.0 (swiftpm-???) (Use swift build --version in Terminal)
@tahirmt
Copy link
Author

tahirmt commented Dec 9, 2021

Closing this since we already have Quick/Quick#1084

@tahirmt tahirmt closed this as completed Dec 9, 2021
@CraigSiemens
Copy link

CraigSiemens commented May 18, 2022

I think this could stay open as Nimble would also need its own changes to properly support swift concurrency. For example expect(...) doesnt support being passed an awaiting function call.

@tahirmt
Copy link
Author

tahirmt commented May 18, 2022

That’s a good point. I’ll reopen.

@tahirmt tahirmt reopened this May 18, 2022
@younata
Copy link
Member

younata commented Oct 22, 2022

This was addressed in #1004!

@younata younata closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants