chore(docs): add rtl support #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I had to proofread my contribution several times and refine it a little. |
QuiiBz
requested changes
Oct 30, 2023
Co-authored-by: Tom Lienard <tom.lienrd@gmail.com>
Co-authored-by: Tom Lienard <tom.lienrd@gmail.com>
Co-authored-by: Tom Lienard <tom.lienrd@gmail.com>
QuiiBz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I've added a documentation page about RTL support, as we previously discussed here: #220
I've documented two possible implementations.
However, the second, proposing an implementation based on a useEffect call, seems to be a bad choice, after some rethinking.
I've written the documentation for it anyway in this PR, but I think we should remove it because of the point I mentioned in "Caveat".
As a reminder, we thought this might be a good idea here:
<html>tagdirattribute #220 (comment)<html>tagdirattribute #220 (comment)Thanks in advance for your review and for your feedback.
Closes #220