chat api improvements for probably after 1.20 because i took too long #311
Conversation
All squashed commits, newest first: Cleanup some line lengths, signing rollback support Add getters and `withX` methods to CommandC2SMessage remove some unused shadows mappings note, server side message removal (i think) whoops missed a `with` method client side message removal events minor cleanup Honestly just need to save this work Server side commands and verification Move chat hook to impl, add hook origin in errors minor cleanup Honestly just need to save this work Server side commands and verification Move chat hook to impl, add hook origin in errors
…e, fix text classes
All squashed commits, newest first: Cleanup some line lengths, signing rollback support Add getters and `withX` methods to CommandC2SMessage remove some unused shadows mappings note, server side message removal (i think) whoops missed a `with` method client side message removal events minor cleanup Honestly just need to save this work Server side commands and verification Move chat hook to impl, add hook origin in errors minor cleanup Honestly just need to save this work Server side commands and verification Move chat hook to impl, add hook origin in errors
…e, fix text classes
EnnuiL
added
library: management
EnnuiL
added
t: new api
|
i thought i could have merged this pr quickly.. |
|
would you mind elaborating? im a little confused on what youre referring to or why it involves closing my pr |
There is multiple QSL maintainers. This PR can be handled by another team member. |
library/management/chat/src/main/java/org/quiltmc/qsl/chat/api/ChatSecurityRollbackSupport.java
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Provides a method to get a {@link ChatSecurityRollbackSupport} from a {@link MessageChain.Packer} or {@link MessageChain.Unpacker}. | ||
| * This class has been provided as API in the case that a user wishes to replace or extend the builtin chat signing system. |
There was a problem hiding this comment.
Dumb question: Why?
When might a mod want to replace/extend the chat signing system?
There was a problem hiding this comment.
Hm i think that might be some off docs on my part
essentially there isnt any way to automatically track the state behind custom (un)packers since theyre a FunctionalInterface, so the idea was that if you create a custom (un)packer for any reason, i.e a custom verification system (e2e) or just adding logging, other small tweaks, ect, you could easily register it here
the lookup has to exist anyways, so i didnt see much reason to not just, allow people to register custom ones easily
This took a while, probably lots of nitpicking to do (especially with javadoc)
Changes:
TypedChatApiHookis no longer apiTesting:
This PR is mostly tested locally, but because i only have 1 minecraft account and no friends, i couldn't test several sections of this PR, notably:
INBOUND CLIENT CHAT/msg, especially between players not privy to the conversation