This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Extend "raw_filters" in categories definitions for OSM POIs, to allow "cuisine" filter #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
previously approved these changes
Jun 14, 2021
idunn/utils/categories.yml
Outdated
| - class: "restaurant" | ||
| cuisine: "burger" | ||
| - class: "fast_food" | ||
| cuisine: "pizza" |
There was a problem hiding this comment.
Seems like a small typo:
Suggested change
| cuisine: "pizza" | |
| cuisine: "burger" |
There was a problem hiding this comment.
Thanks! It was certain that I would miss something in this file.
remi-dupre
approved these changes
Jun 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "categories.yaml", the
raw_filters(used in ES queries) are now defined with objects that accept the following keys :class,subclass,cuisine.The new
MimirPoiFilteris responsible for translating these values into appropriatepoi_type.namevalues (see Qwant/fafnir#61)All functions related to queries in ES for documents built by Mimirsbrunn importers are moved to "idunn/datasources/mimirsbrunn.py".
The new implementation removes a deprecated behavior about "class" filters: both
{poi_class}andclass_{poi_class}were accepted. The first format is obsolete. That's why a few existing fixtures need to be updated.