This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
categories.yml: update definitions for leisure and administrative (pj) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
reviewed
Jun 17, 2021
idunn/utils/categories.yml
Outdated
Comment on lines
14
to
16
| - subclass: "art_gallery" | ||
| - subclass: "art_center" | ||
| - subclass: "gallery" |
There was a problem hiding this comment.
art_gallery does not seem to be a valid subclass. And art_center is actually arts_centre.
(Yes this nomenclature is a bit of a mess).
Suggested change
| - subclass: "art_gallery" | |
| - subclass: "art_center" | |
| - subclass: "gallery" | |
| - subclass: "arts_center" | |
| - subclass: "gallery" |
amatissart
approved these changes
Jun 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leisure contains most POIs from other categories cinema, theatre and attraction. From attraction I didn't included POIs with sublass
attractionorartworksince most of them are historic places (I think leisure should be related to activities).For admistrative POIs, the search "service public" seems slightly off-topic but gives quite convincing results: