This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
block/description: support OSM's description when country lang is known
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
force-pushed
the
osm-description-for-countries
branch
from
b15a228
to
5df0307
Compare
remi-dupre
force-pushed
the
osm-description-for-countries
branch
from
5df0307
to
8c6b153
Compare
remi-dupre
force-pushed
the
osm-description-for-countries
branch
from
8c6b153
to
58f7563
Compare
bbecquet
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSM's
descriptionblock is quite abundant but not integrated in #263.This PR supports it for a bunch of countries with a unique official language if the user language matches the local languages.
I manually referenced European Union countries together with US and UK which should cover most of our users. I didn't want to only stick to France as adding this kind of information is quite light to add in Idunn, but sadly I didn't manage to put hands on a good exhaustive database.