This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
add new block stars
#269
Merged
add new block stars
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
force-pushed
the
block-stars
branch
2 times, most recently
from
8237455
to
7fac954
Compare
remi-dupre
force-pushed
the
block-stars
branch
from
7fac954
to
8e20ccd
Compare
amatissart
reviewed
Aug 17, 2021
idunn/places/pj_poi.py
Outdated
| @@ -535,3 +535,21 @@ def has_takeaway(self): | |||
| for desc in self.data.business_descriptions | |||
| for label in desc.values | |||
| ) | |||
|
|
|||
| HOTEL_STARS_REGEX = re.compile(r"hôtel (?P<rating>\d) étoiles") | |||
There was a problem hiding this comment.
What about hotels with just 1 star ?
Suggested change
| HOTEL_STARS_REGEX = re.compile(r"hôtel (?P<rating>\d) étoiles") | |
| HOTEL_STARS_REGEX = re.compile(r"hôtel (?P<rating>\d) étoiles?") |
Comment on lines
+46
to
+49
| for kind, stars in [ | ||
| (StarsKind.LODGING, place.get_lodging_stars()), | ||
| (StarsKind.RESTAURANT, place.get_restaurant_stars()), | ||
| ] |
There was a problem hiding this comment.
To help with the integration, perhaps we could keep only one of these ratings, depending on place.get_class_name() ?
Then the client could just append the number of stars with the title of the poi class/subclass, without any redundant implementation on both sides, or risk of confusion.
There was a problem hiding this comment.
What I had in mind is that erdapfel would blindly display all items of the list, but maybe we risk displaying irrelevant data?
remi-dupre
force-pushed
the
block-stars
branch
from
8367599
to
4a7e647
Compare
amatissart
reviewed
Aug 19, 2021
idunn/blocks/stars.py
Outdated
Comment on lines
23
to
28
| def check_class(self, subclass: Optional[str]) -> bool: | ||
| return (self, subclass) in [ | ||
| (self.LODGING, "lodging"), | ||
| (self.RESTAURANT, "restaurant"), | ||
| (self.RESTAURANT, "fast_food"), | ||
| ] |
There was a problem hiding this comment.
subclass should rather be named class_name
There was a problem hiding this comment.
I just rewrote last commit as this is a very minor change.
remi-dupre
force-pushed
the
block-stars
branch
from
4a7e647
to
b30744c
Compare
amatissart
approved these changes
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
starsblock which indicates if the POI is a starred restaurant or hotel and eventually gives its rating.The format looks like follows:
{ "type": "stars", "ratings": [ {"has_stars": "yes", "nb_stars": 4.0, "kind": "lodging"} ] }{ "type": "stars", "ratings": [ {"has_stars": "yes", "nb_stars": null, "kind": "restaurant"} ] }