-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐞] onSubmitCompleted$ is always triggered, even when fails #4257
Comments
I opened the PR 4397 that fix it. |
Wondering if this is an bug. We could add add |
HI @manucorporat. What is exactly your doubt if it is a bug or not? Can you explain in detail your thoughts? Regarding the submit failure, I ran it many times the tests locally and it works, tbh I don't have any clue why it is failing via CI. I checked out the logs but I didn't find out the root cause. I will review the code again and try to apply your suggestion: add Thank you to take a look at it. |
the API should be reworked maybe in v2 |
Which component is affected?
Qwik Runtime
Describe the bug
According to the documentation
onSubmitCompleted$
should be executed right after the action is executed successfully and returns some data. The issue: it is always executed no matter Zod validation fails or I returnfail
insideactionRoute$
.Reproduction
N/A
Steps to reproduce
You can use this code:
Additional Information
No response
The text was updated successfully, but these errors were encountered: