Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Form): multi onSubmit$ handlers #6241

Merged
merged 20 commits into from
May 10, 2024
Merged

Conversation

PatrickJS
Copy link
Member

allow for an array of events for onSubmit$

also fixes #4908

Copy link

cloudflare-pages bot commented May 6, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b32f14
Status: ✅  Deploy successful!
Preview URL: https://b34efd07.qwik-8nx.pages.dev
Branch Preview URL: https://feat-multiple-onsubmit-form.qwik-8nx.pages.dev

View logs

@PatrickJS PatrickJS marked this pull request as ready for review May 6, 2024 07:24
@PatrickJS PatrickJS assigned PatrickJS and unassigned PatrickJS May 6, 2024
@PatrickJS PatrickJS force-pushed the feat-multiple-onSubmit-form branch from 4c42220 to e9a510e Compare May 9, 2024 18:38
@PatrickJS PatrickJS changed the title feat(Form): multi onSubmit$ feat(Form): multi onSubmit$ handlers May 9, 2024
Copy link
Contributor

@hamatoyogi hamatoyogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a test as well to make sure it works and also one (currently failing, but could be skipped) for v2

@PatrickJS
Copy link
Member Author

I made it additional api and in v2 we can make it slightly breaking api

@PatrickJS
Copy link
Member Author

I added a test

@PatrickJS PatrickJS force-pushed the feat-multiple-onSubmit-form branch from 6258f58 to 8ad3ae1 Compare May 10, 2024 01:23
@PatrickJS
Copy link
Member Author

ok test added and all green

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit ac6ea5c into main May 10, 2024
24 checks passed
@wmertens wmertens deleted the feat-multiple-onSubmit-form branch May 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] onSubmit$ attribute of the Form component doesn't work when using method get
3 participants