refactor(core): extract Group type

[wtlin1228]

Overview

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

While going over the Qwik source code, I noticed SubscriberEffect | SubscriberHost | Node type is used in many places that might be clearer if it is extracted into a standalone Group type.

I was considering to derive Group type from Subscriptions type like the following because group can only be the host of subscription.

type Group = Subscriptions[1]; // SubscriberEffect | QwikElement | Text

But that will cause a problem in the cleanupTree. So I decided not to do so in this PR.

export const cleanupTree = (
  elm: Node | VirtualElement,
  // ...
) => {
  // ❌ Type 'Node' is not assignable to type 'SubscriberEffect | QwikElement | Text'.
  subsManager.$clearSub$(elm); 
  // ...
};

Use cases and why

• 1. One use case
• 2. Another use case

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[netlify]

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	86aa061

[wmertens]

Thanks!