fix(qwik): handle cypress dev server path #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
gioboa
approved these changes
Dec 1, 2023
gioboa
added
COMP: qwik-city
WAITING FOR: team
|
Thank you @dmitry-stepanenko ! |
dmitry-stepanenko
force-pushed
the
ds/handle-cypress-dev-server-path
branch
from
ccb1b48
to
1b3267e
Compare
petebacondarwin
pushed a commit
to petebacondarwin/qwik
that referenced
this pull request
Dec 4, 2023
Co-authored-by: gioboa <giorgiob.boa@gmail.com>
kodiakhq bot
pushed a commit
to ascorbic/unpic-img
that referenced
this pull request
Dec 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.2.19` -> `1.3.0`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.19/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.3.0`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.0) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.19...v1.3.0) #### Breaking Changes - When passing a `Signal` into `track()` directly (instead of passing a function), it returns the signal value instead of the signal itself. This behavior was already present when running inside a `useResource$` callback, and now it is consistent across all Tasks. #### What's Changed - chore: Vite 5 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5451 - feat: add qwik/no-use-visible-task eslint rule by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5455 - chore(insights): remove unnecessary log by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5461 - fix: add example context to docs by [@​dotarjun](https://togithub.com/dotarjun) in [QwikDev/qwik#5467 - feat(qwik-city): allow customizing SVGO options of image plugin by [@​hbendev](https://togithub.com/hbendev) in [QwikDev/qwik#5407 - docs: fix typo by [@​ulic75](https://togithub.com/ulic75) in [QwikDev/qwik#5472 - docs: fix typo by [@​Adbib](https://togithub.com/Adbib) in [QwikDev/qwik#5481 - fix(core): Support JSX in signals by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5442 - docs(FAQ): - lazy-loading on user interaction & speculative module fetching by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5488 - docs(faq): add link to typescript by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5487 - fix: disable Vite modulepreload by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5493 - docs(faq): fix typos and improve the wording of some sentences by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5490 - docs: make the distinction between module-prefetching and <Link prefetch> by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5485 - docs(showcase): add `index.app` and `wiza.co` by [@​necatikcl](https://togithub.com/necatikcl) in [QwikDev/qwik#5484 - fix(docs): mdx interpreting title as component by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5499 - docs(/faq#vdom): cleanup the vdom section by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5500 - fix: revert "fix: remove cf pages stream polyfill" by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5502 - fix(qwik-city): prefix ids of SVGs based on their path when loaded as qwik nodes by [@​hbendev](https://togithub.com/hbendev) in [QwikDev/qwik#5497 - fix: cf pages polyfill only if needed by [@​mpeg](https://togithub.com/mpeg) in [QwikDev/qwik#5507 - refactor(core): extract Group type by [@​wtlin1228](https://togithub.com/wtlin1228) in [QwikDev/qwik#4798 - docs: add QwikCityMockProvider explanation by [@​mulztob](https://togithub.com/mulztob) in [QwikDev/qwik#5505 - docs(glob-import): add documentation for import.meta.glob by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5504 - fix: CF pages polyfill also when shimmed by [@​mpeg](https://togithub.com/mpeg) in [QwikDev/qwik#5512 - fix(qwik): handle cypress dev server path by [@​dmitry-stepanenko](https://togithub.com/dmitry-stepanenko) in [QwikDev/qwik#5509 - chore(cf): Fix CloudFlare build failure by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5524 - docs: removed defunct sites by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5528 - chore(netlify): fix netlify failure by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5527 - docs(showcase): add juneikerc.com - blog \[prismic cms] and personal website by [@​juneikerc](https://togithub.com/juneikerc) in [QwikDev/qwik#5523 - fix(localization-starter): update docs and add script by [@​tzdesign](https://togithub.com/tzdesign) in [QwikDev/qwik#5494 - chore(qwik-city): bump vite-imagetools ^5 -> ^6 by [@​birkskyum](https://togithub.com/birkskyum) in [QwikDev/qwik#5525 - feat(insights): polish UI by [@​zanettin](https://togithub.com/zanettin) in [QwikDev/qwik#5503 - chore: update .nvmrc by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5530 - feat(insight): Add user auth to only see your app data. by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5517 - chore(ci): set up CI for insights and docs by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5533 - refactor(types): more precision by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5531 - chore: 1.3.0 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5535 #### New Contributors - [@​dotarjun](https://togithub.com/dotarjun) made their first contribution in [QwikDev/qwik#5467 - [@​Adbib](https://togithub.com/Adbib) made their first contribution in [QwikDev/qwik#5481 - [@​mulztob](https://togithub.com/mulztob) made their first contribution in [QwikDev/qwik#5505 - [@​juneikerc](https://togithub.com/juneikerc) made their first contribution in [QwikDev/qwik#5523 - [@​birkskyum](https://togithub.com/birkskyum) made their first contribution in [QwikDev/qwik#5525 **Full Changelog**: QwikDev/qwik@v1.2.19...v1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding a cypress dev server prefix to the regexp of
shouldSsrRenderfunctionWhat is it?
Description
Cypress tries to load vite assets using a slightly different path than we usually have: it adds
/__cypress/srcprefix so we end up having paths like/__cypress/src/@vite/client. This is not caught by the VITE_PUBLIC_PATH regex part here https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/optimizer/src/plugins/vite-server.ts#L291 because it checks for the /@vite/ part to be at the beginning of the url's pathname.Use cases and why
Checklist: