docs: emphasize on useStore and onInput$ #5719

Balastrong · 2024-01-15T18:58:24Z

The examples with signals and binding are mostly with onClick$ and numbers.

Something that isn't mentioned often is that:

Values from useStore cannot be used for bind:propertyName
Text inputs shouldn't be controlled with onChange$ but with onInput$

I mentioned this in some pages where I think it makes sense as otherwise it can lead to quite some confusion.

…s with useInput

netlify · 2024-01-15T18:58:27Z

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`124d0aa`

packages/docs/src/routes/docs/(qwik)/components/rendering/index.mdx

packages/docs/src/routes/docs/(qwik)/components/state/index.mdx

gioboa

Thanks @Balastrong
I suggested few small changes but it looks great.

packages/docs/src/routes/demo/state/counter-store/index.tsx

…x.mdx Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>

Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>

Balastrong · 2024-01-15T19:38:04Z

I had a look at the suggestions and they definitely look reasonable, thanks for the review @gioboa :)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.2` -> `1.4.3`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.2/1.4.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@builder.io%2fqwik/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@builder.io%2fqwik/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@builder.io%2fqwik/1.3.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@builder.io%2fqwik/1.3.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@builder.io/qwik)</summary> ### [`v1.4.3`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.3) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.2...v1.4.3) #### What's Changed - chore(vite): downgrade vite version by [@balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) in [QwikDev/qwik#5785 - fix(starter): adjust padding for 768px devices by [@balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) in [QwikDev/qwik#5787 - chore: lint++ by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5788 - fix(qwik-city): fix import ./[@qwik-city](https://togithub.com/qwik-city) files in prod by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5791 - fix(qwik-auth): lock down `@auth/core` version by [@balazsorban44](https://togithub.com/balazsorban44) in [QwikDev/qwik#5790 - chore(docs): align indentation by [@greatgraphicdesign](https://togithub.com/greatgraphicdesign) in [QwikDev/qwik#5792 - chore(docs): Update to latest builder.io/sdk-qwik by [@STRd6](https://togithub.com/STRd6) in [QwikDev/qwik#5794 - docs: Redirect all requests from builder.io to the qwik.dev domain. by [@mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5796 - feat(QwikCityMockProvider): add optional goto prop by [@alexismch](https://togithub.com/alexismch) in [QwikDev/qwik#5779 - chore(starters): update 🐼 PandaCSS integration starter dev dependency by [@mrhoodz](https://togithub.com/mrhoodz) in [QwikDev/qwik#5797 - feat(qwik): configure sourcemap in optimizer by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5799 - chore: 1.4.3 by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5800 #### New Contributors - [@balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) made their first contribution in [QwikDev/qwik#5785 - [@balazsorban44](https://togithub.com/balazsorban44) made their first contribution in [QwikDev/qwik#5790 - [@greatgraphicdesign](https://togithub.com/greatgraphicdesign) made their first contribution in [QwikDev/qwik#5792 - [@alexismch](https://togithub.com/alexismch) made their first contribution in [QwikDev/qwik#5779 **Full Changelog**: QwikDev/qwik@v1.4.2...v1.4.3 ### [`v1.4.2`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.2) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.1...v1.4.2) ##### What's Changed - fix(docs): Sandbox playground iframe by [@STRd6](https://togithub.com/STRd6) in [QwikDev/qwik#5768 - docs(astro): update integration doc by [@thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5771 - docs: add note about Astro integrations order importance by [@Seanmclem](https://togithub.com/Seanmclem) in [QwikDev/qwik#5776 - feat(dev): preload modules for / so dev starts faster by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5775 - fix: SW cache race condition by [@thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5780 - chore: 1.4.2 by [@thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5781 ##### New Contributors - [@Seanmclem](https://togithub.com/Seanmclem) made their first contribution in [QwikDev/qwik#5776 **Full Changelog**: QwikDev/qwik@v1.4.1...v1.4.2 ### [`v1.4.1`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.1) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.0...v1.4.1) ##### Overview - Try harder to prevent dirty tasks on SSR - AWS middleware in `qwik-city` - File filter option to make Qwik work better with Astro - `qwik-auth` can now handle multiple cookies - Node adapters in `qwik-city` now read .env files - Bugfixes in various service workers, starter CSS build, etc - Dependency updates Thanks to all contributors! ##### Commits - chore(starters): update 🐼 PandaCSS integration dev dependency by [@mrhoodz](https://togithub.com/mrhoodz) in [QwikDev/qwik#5739 - docs: add Valibot website to showcases by [@fabian-hiller](https://togithub.com/fabian-hiller) in [QwikDev/qwik#5740 - fix: multiple cookies in qwik-auth by [@ksjogo](https://togithub.com/ksjogo) in [QwikDev/qwik#5602 - feat(qwik-city): AWS adapter middleware by [@leifermendez](https://togithub.com/leifermendez) in [QwikDev/qwik#5732 - docs: fix code highlight by downgrading rehype-pretty-code by [@Balastrong](https://togithub.com/Balastrong) in [QwikDev/qwik#5742 - feat(starters): add dotenv in node adapters by [@hassanzohdy](https://togithub.com/hassanzohdy) in [QwikDev/qwik#5749 - fix(docs): Validate origin on postmessage by [@STRd6](https://togithub.com/STRd6) in [QwikDev/qwik#5751 - feat(vite): new file filter option by [@thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5752 - fix(ssr): dirty tasks by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5741 - fix(qwik): ensure that SW cache is properly opened by [@mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5748 - fix: insights error handling and qwik-city json imports by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5754 - fix(prefetch-sw): await cache opening by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5759 - chore: updates by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5760 - fix(sw-prefetch): prevent uninitialized cache use by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5761 - fix(sw-prefetch): cache handling by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5764 - fix: duplicated css code in global.css in starter template by [@linkfang](https://togithub.com/linkfang) in [QwikDev/qwik#5763 - feat(repl): use bundled qwik and prettier versions by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5755 - fix(sw-prefetch): clone on reuse by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5765 - chore: 1.4.1 by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5766 ##### New Contributors - [@STRd6](https://togithub.com/STRd6) made their first contribution in [QwikDev/qwik#5751 **Full Changelog**: QwikDev/qwik@v1.4.0...v1.4.1 ### [`v1.4.0`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.0) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.5...v1.4.0) ##### What's Changed - Types have changed a bit, now JSX components output `JSXOutput` instead of `JSXNode`, which captures the existing possibility to return strings, booleans, arrays etc. - The Link component now automatically prefetches the JS needed - When SPA routing fails, it will now use MPA routing as a fallback - Various bugfixes ##### PRs merged - docs(showcase): add Blueagle's Profolio & Blog by [@blueagler](https://togithub.com/blueagler) in [QwikDev/qwik#5695 - docs(showcase): update metrics by [@gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5707 - fix(types): untyped components, test more edge cases by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5713 - docs(showcase): add Zhou's portfolio by [@linkfang](https://togithub.com/linkfang) in [QwikDev/qwik#5710 - chore: upgrades by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5705 - fix(qwik): register new index.d.ts package file by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5715 - docs: move props example after local state and useStore explanation by [@Balastrong](https://togithub.com/Balastrong) in [QwikDev/qwik#5718 - docs: emphasize on useStore and onInput$ by [@Balastrong](https://togithub.com/Balastrong) in [QwikDev/qwik#5719 - docs: add Storybook Examples by [@thenhawke](https://togithub.com/thenhawke) in [QwikDev/qwik#5720 - fix(jsx-qwik-attributes): fix ts error TS4023 by [@maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5722 - fix(types): JSX.Element is JSXOutput by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5723 - fix: prevent race condition by [@mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5711 - fix: build from scratch + insights by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5724 - docs: Good first issue link doesn't lead you to properly label "COMMUNITY: good first issue" by [@aendel](https://togithub.com/aendel) in [QwikDev/qwik#5726 - docs: fixed CodeSandbox/CodeFile src paths to match github files by [@aendel](https://togithub.com/aendel) in [QwikDev/qwik#5725 - fix: Uppercase handling for SameSite cookie values by [@ksjogo](https://togithub.com/ksjogo) in [QwikDev/qwik#5603 - feat(link): prefetch symbols by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5480 - docs: Fixed various typos (or misspelled words) in documentation files by [@aendel](https://togithub.com/aendel) in [QwikDev/qwik#5728 - chore: extra type tests by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5580 - fix(build): qwik binary path in package.json by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5729 - fix(routing): fallback to hard navigation when soft navigation fails. by [@iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5521 - fix(JSX): remove Promise from FC by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5730 - fix(core): serialize the 'key' attribute of JSX nodes by [@yanivhamo](https://togithub.com/yanivhamo) in [QwikDev/qwik#5501 - fix(repl): give monaco the names of the imports by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5734 - docs(cookbook): add Combine Request Handlers example by [@gioboa](https://togithub.com/gioboa) and [@erikras](https://togithub.com/erikras) in [QwikDev/qwik#5733 - fix(docs): grammar in "Project Structure" page by [@ChallengeHandler](https://togithub.com/ChallengeHandler) in [QwikDev/qwik#5735 - chore: 1.4.0 by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5736 ##### New Contributors - [@blueagler](https://togithub.com/blueagler) made their first contribution in [QwikDev/qwik#5695 - [@linkfang](https://togithub.com/linkfang) made their first contribution in [QwikDev/qwik#5710 - [@Balastrong](https://togithub.com/Balastrong) made their first contribution in [QwikDev/qwik#5718 - [@thenhawke](https://togithub.com/thenhawke) made their first contribution in [QwikDev/qwik#5720 - [@aendel](https://togithub.com/aendel) made their first contribution in [QwikDev/qwik#5726 - [@ksjogo](https://togithub.com/ksjogo) made their first contribution in [QwikDev/qwik#5603 - [@yanivhamo](https://togithub.com/yanivhamo) made their first contribution in [QwikDev/qwik#5501 - [@ChallengeHandler](https://togithub.com/ChallengeHandler) made their first contribution in [QwikDev/qwik#5735 **Full Changelog**: QwikDev/qwik@v1.3.5...v1.4.0 ### [`v1.3.5`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.5) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.4...v1.3.5) #### What's Changed - docs: fix typos for theme management cookbook by [@harshmangalam](https://togithub.com/harshmangalam) in [QwikDev/qwik#5698 - fix(labs): double slash when used with BASE_URL by [@mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5700 - fix: improve escapeText and unescapeText replace to prevent XSS by [@ignatvilesov](https://togithub.com/ignatvilesov) in [QwikDev/qwik#5701 - chore: allow any undici version by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5703 - docs(propfunctionprops): mark propfunctionprops as deprecated by [@maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5680 - chore: 1.3.5 by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5704 **Full Changelog**: QwikDev/qwik@v1.3.4...v1.3.5 ### [`v1.3.4`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.4) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.3...v1.3.4) ##### What's Changed - chore: update deps + monaco by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5685 - chore: Remove duplicated dist directory from .prettierignore by [@nelsonprsousa](https://togithub.com/nelsonprsousa) in [QwikDev/qwik#5687 - docs: add og-img integration guide by [@fabian-hiller](https://togithub.com/fabian-hiller) in [QwikDev/qwik#5686 - chore: improve FunctionComponent by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5688 - fix: improve escapeText replace by [@ignatvilesov](https://togithub.com/ignatvilesov) in [QwikDev/qwik#5689 - fix(optimizer): use correct prop in omit by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5690 - chore: 1.3.4 by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5691 - docs: fix typos for nav link cookbook by [@harshmangalam](https://togithub.com/harshmangalam) in [QwikDev/qwik#5694 ##### New Contributors - [@ignatvilesov](https://togithub.com/ignatvilesov) made their first contribution in [QwikDev/qwik#5689 **Full Changelog**: QwikDev/qwik@v1.3.3...v1.3.4 ### [`v1.3.3`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.3) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.2...v1.3.3) ##### What's Changed - fix(cli): Update jokes.json by [@mayank99](https://togithub.com/mayank99) in [QwikDev/qwik#5657 - docs: for accessing the .env variables in serverfull architechture example in express by [@sreeisalso](https://togithub.com/sreeisalso) in [QwikDev/qwik#5619 - docs: change placement of {...props} and add section by [@Adbib](https://togithub.com/Adbib) in [QwikDev/qwik#5664 - docs: Update build command in Static Site Generation (SSG) Overview docs by [@lelouchB](https://togithub.com/lelouchB) in [QwikDev/qwik#5668 - fix(starter): rename tailwind postcss.config file by [@iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5669 - fix: fixing running qwik-development-server on windows machine by [@hassanzohdy](https://togithub.com/hassanzohdy) in [QwikDev/qwik#5593 - fix(starter): add vite plugin type by [@iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5670 - feat(qwik-react): directive aliases for Astro and other package conflicts by [@thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5651 - feat: qwik-prefetch-worker by [@mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5618 - refactor: Clarify var naming qwikloader.ts by [@gabrielgrant](https://togithub.com/gabrielgrant) in [QwikDev/qwik#5546 - docs: fix entry file name by [@AustinGil](https://togithub.com/AustinGil) in [QwikDev/qwik#5646 - feat(labs): Support base prefix in untypedAppUrl by [@tera-ny](https://togithub.com/tera-ny) in [QwikDev/qwik#5615 - style(starter templates): updates to starter templates names by [@abstractalgo](https://togithub.com/abstractalgo) in [QwikDev/qwik#5479 - fix: Clearer error message for `resolveValue` for `head` function by [@colelawrence](https://togithub.com/colelawrence) in [QwikDev/qwik#5624 - refactor(starter): add alt attribute in order to improve accessibility by [@tidiview](https://togithub.com/tidiview) in [QwikDev/qwik#5674 - refactor(insights): remove netlify.toml causing confusion by [@mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5676 - feat(cookbook): add Algolia search by [@gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5675 - fix(cookbook): change Algolia example by [@gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5677 - fix: polymorphic component types by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5672 - chore: add Nix build flake environment by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5594 - fix(nix): missing .envrc by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5678 - fix(nix): make rust and wasm builds work by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5679 - fix: dynamic refs by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5681 - fix(core): Make polymorphic components easy by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5682 - chore: 1.3.3 by [@wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5683 ##### New Contributors - [@mayank99](https://togithub.com/mayank99) made their first contribution in [QwikDev/qwik#5657 - [@lelouchB](https://togithub.com/lelouchB) made their first contribution in [QwikDev/qwik#5668 - [@hassanzohdy](https://togithub.com/hassanzohdy) made their first contribution in [QwikDev/qwik#5593 - [@AustinGil](https://togithub.com/AustinGil) made their first contribution in [QwikDev/qwik#5646 - [@tera-ny](https://togithub.com/tera-ny) made their first contribution in [QwikDev/qwik#5615 **Full Changelog**: QwikDev/qwik@v1.3.2...v1.3.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img).

Balastrong added 2 commits January 15, 2024 19:19

docs: show onInput to sync a text input and a string on useStore

ed4b51f

docs: emphasize that strings from useStore needs to be bound to input…

43347a4

…s with useInput

gioboa reviewed Jan 15, 2024

View reviewed changes

packages/docs/src/routes/docs/(qwik)/components/rendering/index.mdx Outdated Show resolved Hide resolved

gioboa reviewed Jan 15, 2024

View reviewed changes

packages/docs/src/routes/docs/(qwik)/components/state/index.mdx Outdated Show resolved Hide resolved

gioboa requested changes Jan 15, 2024

View reviewed changes

packages/docs/src/routes/demo/state/counter-store/index.tsx Outdated Show resolved Hide resolved

Balastrong and others added 3 commits January 15, 2024 20:36

Update packages/docs/src/routes/docs/(qwik)/components/rendering/inde…

c030ede

…x.mdx Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>

Update packages/docs/src/routes/docs/(qwik)/components/state/index.mdx

847e05b

Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>

Update packages/docs/src/routes/demo/state/counter-store/index.tsx

124d0aa

Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>

gioboa approved these changes Jan 15, 2024

View reviewed changes

gioboa merged commit 7e256a9 into QwikDev:main Jan 15, 2024
22 checks passed

Balastrong deleted the docs/mention-input-store-handling branch January 15, 2024 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: emphasize on useStore and onInput$ #5719

docs: emphasize on useStore and onInput$ #5719

Balastrong commented Jan 15, 2024

netlify bot commented Jan 15, 2024 •

edited

gioboa left a comment

Balastrong commented Jan 15, 2024

docs: emphasize on useStore and onInput$ #5719

docs: emphasize on useStore and onInput$ #5719

Conversation

Balastrong commented Jan 15, 2024

netlify bot commented Jan 15, 2024 • edited

👷 Deploy request for qwik-insights pending review.

gioboa left a comment

Choose a reason for hiding this comment

Balastrong commented Jan 15, 2024

netlify bot commented Jan 15, 2024 •

edited