Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use assetsDir in the qwikVite plugin #6522

Merged
merged 8 commits into from
Jun 12, 2024
Merged

feat: use assetsDir in the qwikVite plugin #6522

merged 8 commits into from
Jun 12, 2024

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jun 12, 2024

Closed #6509

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner June 12, 2024 03:46
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2024 •
edited
Loading

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 616c84f

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 12, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (616c84f)

npm i https://pkg.pr.new/@builder.io/qwik@6522

@builder.io/qwik-city (616c84f)

npm i https://pkg.pr.new/@builder.io/qwik-city@6522

eslint-plugin-qwik (616c84f)

npm i https://pkg.pr.new/eslint-plugin-qwik@6522

create-qwik (616c84f)

npm i https://pkg.pr.new/create-qwik@6522

wmertens
wmertens approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 9f23d3e into QwikDev:main Jun 12, 2024
20 checks passed
@gioboa gioboa deleted the feat/use-assetsDir branch June 12, 2024 12:00
gioboa added a commit to gioboa/qwik that referenced this pull request Jun 20, 2024
@gioboa
revert: QwikDev#6522 & QwikDev#6526
af7ffe5
PatrickJS pushed a commit that referenced this pull request Jun 20, 2024
@gioboa
revert: #6522 & #6526 (#6583)
59a45ab
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
@gioboa @genki
feat: use assetsDir in the qwikVite plugin (QwikDev#6522)
64d68a4 
* feat: use assetsDir in the qwikVite plugin

Closed QwikDev#6509

* fix: concatenate outDir and assetsDir

* fix: remove CLIENT_OUT_DIR fallback

* fix: change logic to prevent regressions

* chore: linter 🧽

* test: add build.assetsDir tests

* chore: linter 🧽

* test: fix up build.assetsDir tests
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
@gioboa @genki
revert: QwikDev#6522 & QwikDev#6526 (QwikDev#6583)
84f79b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorMinar IgorMinar IgorMinar left review comments

@wmertens wmertens wmertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] Vite's assetDir is not honored by Qwik
3 participants
@gioboa @wmertens @IgorMinar