Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Win environment #6526

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jun 12, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner June 12, 2024 15:30
Copy link

netlify bot commented Jun 12, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 27be44e

Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

Copy link

pkg-pr-new bot commented Jun 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (27be44e)

npm i https://pkg.pr.new/@builder.io/qwik@6526

@builder.io/qwik-city (27be44e)

npm i https://pkg.pr.new/@builder.io/qwik-city@6526

eslint-plugin-qwik (27be44e)

npm i https://pkg.pr.new/eslint-plugin-qwik@6526

create-qwik (27be44e)

npm i https://pkg.pr.new/create-qwik@6526

@wmertens wmertens merged commit 0aba578 into QwikDev:main Jun 12, 2024
20 checks passed
@gioboa gioboa deleted the fix/preserv-win-env branch June 12, 2024 16:22
gioboa added a commit to gioboa/qwik that referenced this pull request Jun 20, 2024
PatrickJS pushed a commit that referenced this pull request Jun 20, 2024
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants