Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Notifications #213

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Implement Notifications #213

merged 2 commits into from
Jul 30, 2023

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Jul 22, 2023

Closing #89

We now send notifications to the user if anything went wrong while running the OCR process. Of course the Notification app has to be installed for this feature to work correctly.

grafik

TODO:

  • Documentation

@R0Wi R0Wi linked an issue Jul 22, 2023 that may be closed by this pull request
@R0Wi R0Wi requested a review from bahnwaerter July 22, 2023 14:28
* Add documentation
* Remove code smells
* Update psalm-baseline to ignore IRootFolder dependency
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your changes and they look good to me. Feel free to merge this new feature.

@R0Wi R0Wi merged commit 3aebf0f into master Jul 30, 2023
17 checks passed
R0Wi added a commit that referenced this pull request Jul 30, 2023
* Implement Notifications

* Notification adjustments

* Add documentation
* Remove code smells
* Update psalm-baseline to ignore IRootFolder dependency
R0Wi added a commit that referenced this pull request Jul 30, 2023
* Implement Notifications

* Notification adjustments

* Add documentation
* Remove code smells
* Update psalm-baseline to ignore IRootFolder dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

somehow report back errors to user?
2 participants