Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added display character frame #31
Added display character frame #31
Changes from all commits
951b88b
eab49c8
fa4b669
2a781e3
fc8a61a
5a227a2
b62a22c
debf438
71832b7
a0c0e25
969fb23
9c66184
1fbc739
dc2b0b0
4b0d85c
7975114
b717cf6
cb7e6ec
c98da93
f857a23
3ed9e25
7d267b5
2bede84
d9c557d
060e79a
f5c3eae
58e4beb
aa158ab
b633204
5a7426a
f3d4ec1
f28e843
34c9b71
6c6237b
83f772e
ce2ae41
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add what location these cursors have? Direct pixel location or the font location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, fixed in 83f772e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked commit doesnt add any documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I hastily made the wrong comment to the wrong change, my bad. I will change it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more documentation about the cursor_id in ce2ae41. If this isn't what you meant, please say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant in hwlib when you write to the screen the location is not directly the pixel you write to. (At leasts when I used it).
So when you wrote to (1, 0) it would write as the second character on the first line. Is this following that principle or can you write to (100, 100) and it will start at pixel (100, 100) and write it from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I read it, this is simply pixel position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sure then it is probably just me.