Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure and improve modding docs #134

Merged
merged 34 commits into from
Mar 13, 2023
Merged

Conversation

NoCatt
Copy link
Contributor

@NoCatt NoCatt commented Dec 17, 2022

No description provided.

@NoCatt NoCatt marked this pull request as ready for review March 11, 2023 00:13
@GeckoEidechse
Copy link
Member

Giving the rendered result a quick skim, it looks quite nice. Given the large number of changes I'd say we should try to split out some changes into separate PRs and merge those first in order to slim this one down and make it easier to review ^^

@NoCatt
Copy link
Contributor Author

NoCatt commented Mar 11, 2023

Giving the rendered result a quick skim, it looks quite nice. Given the large number of changes I'd say we should try to split out some changes into separate PRs and merge those first in order to slim this one down and make it easier to review ^^

no

GeckoEidechse pushed a commit that referenced this pull request Mar 11, 2023
Spliced out from refactor PR (#134)
This was referenced Mar 11, 2023
@laundmo
Copy link
Member

laundmo commented Mar 12, 2023

Since i merged some of the changes which were spliced out from this, it needs updating:

Bring refactor PR up-to-date with main
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Mar 12, 2023

Since i merged some of the changes which were spliced out from this, it needs updating:

Done with NoCatt#1

Copy link
Member

@laundmo laundmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall i'm quite happy with how this PR turned out.

docs/source/guides/ToolModding/index.rst Outdated Show resolved Hide resolved
docs/source/guides/keyValueModding/index.rst Outdated Show resolved Hide resolved
docs/source/guides/scriptingGuides/index.rst Outdated Show resolved Hide resolved
docs/source/guides/ToolModding/index.rst Outdated Show resolved Hide resolved
docs/source/guides/keyValueModding/index.rst Outdated Show resolved Hide resolved
docs/source/squirrel/intro.rst Outdated Show resolved Hide resolved
docs/source/squirrel/intro.rst Outdated Show resolved Hide resolved
docs/source/squirrel/intro.rst Outdated Show resolved Hide resolved
docs/source/squirrel/intro.rst Outdated Show resolved Hide resolved
docs/source/squirrel/intro.rst Outdated Show resolved Hide resolved
NoCatt and others added 12 commits March 12, 2023 17:15
Co-authored-by: laund <laurinschmidt2001@gmail.com>
Co-authored-by: laund <laurinschmidt2001@gmail.com>
Co-authored-by: laund <laurinschmidt2001@gmail.com>
Co-authored-by: laund <laurinschmidt2001@gmail.com>
Co-authored-by: laund <laurinschmidt2001@gmail.com>
Co-authored-by: laund <laurinschmidt2001@gmail.com>
@laundmo laundmo changed the title Refactor modding docs Restructure and improve modding docs Mar 13, 2023
@laundmo laundmo merged commit 0220c7e into R2Northstar:main Mar 13, 2023
@laundmo laundmo mentioned this pull request Mar 13, 2023
@NoCatt NoCatt deleted the refactor branch March 13, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants