Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package re-exports #304

Merged
merged 5 commits into from
Sep 7, 2022
Merged

package re-exports #304

merged 5 commits into from
Sep 7, 2022

Conversation

aspina7
Copy link
Member

@aspina7 aspina7 commented Aug 27, 2022

.... not working....

@zkamvar
Copy link
Member

zkamvar commented Aug 30, 2022

The reexports should be working now, you just need to fix the vignette names issue (read: remove the spaces in these names)

@aspina7
Copy link
Member Author

aspina7 commented Aug 31, 2022

You're amazing I love you, will check it out this eve thanks a bunch

@aspina7 aspina7 mentioned this pull request Sep 5, 2022
@aspina7
Copy link
Member Author

aspina7 commented Sep 7, 2022

merging for now as neale has dealt with vignette renaming on another branch

@aspina7 aspina7 merged commit c8a4f8f into master Sep 7, 2022
This was referenced Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants