Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-topic formatting with record data lookup #528

Merged
merged 10 commits into from
Aug 30, 2022
Merged

Conversation

blootsvoets
Copy link
Member

Allow changing the output path per topic based on simple data lookups. This is particularly useful if we add a questionnaire_response topic, which would get multiple questionnaire types. Then the output folder can still be changed based on the name of the questionnaire even though all those questionnaires were originally put in the same topic.

FormattedPathFactory now has an plugin structure, where multiple variable parsers can be inserted via configuration. This can be used in the future for example for adding ManagementPortal properties to the file structure (e.g. externalId, project group or set of related projects).

This anticipates adding additional mappers from the data to the target
file system structure.
Copy link
Member

@nivemaham nivemaham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be useful to have some tests to validate this use case

@blootsvoets blootsvoets merged commit 806e4a8 into dev Aug 30, 2022
@blootsvoets blootsvoets deleted the perTopicFormat branch August 30, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants