Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change DoubleSolenoid shifter to Solenoid #66

Merged
merged 3 commits into from
Jan 27, 2018
Merged

change DoubleSolenoid shifter to Solenoid #66

merged 3 commits into from
Jan 27, 2018

Conversation

iCodeCoolStuff
Copy link
Contributor

Problem

There were too many DoubleSolenoids in TankDrive

Solution

DoubleSolenoid in TankDrive was changed to regular Solenoid

Testing Notes

Used RA17_RobotCode as a reference

@themisfitfox
Copy link
Contributor

I'll handle any codeclimate issues

randomtestfive
randomtestfive suggested changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@randomtestfive randomtestfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable climbing should set true

@randomtestfive randomtestfive added this to the Finish Drivetrain milestone Jan 27, 2018
@randomtestfive randomtestfive merged commit 47fbcb9 into master Jan 27, 2018
@randomtestfive randomtestfive mentioned this pull request Jan 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomtestfive randomtestfive randomtestfive approved these changes

Assignees

@themisfitfox themisfitfox

@iCodeCoolStuff iCodeCoolStuff

Labels
None yet
Projects
None yet
Milestone
Finish Drivetrain
Development

Successfully merging this pull request may close these issues.
3 participants
@iCodeCoolStuff @themisfitfox @randomtestfive