Runscriptmod #1
Merged
Runscriptmod #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current 'run prepare' script uses sudo to create the symlinks for python and nodejs. For many systems, this is unnecessary and causes the user to be presented a request for password. Additionally, this could affect any previous system configuration. This change makes the symlinks only be created if they don't already exist.
… run This commit modifies the run script to add code that captures the PID of the test server and the PGID of the xvfb process group so that it can kill these child processes after the script has run.
…ted and less likely to fail
…dler for ctl-c so that the children get correctly killed on abort
…hort circuit the script if the fail
RCL-Carl
force-pushed
the
runscriptmod
branch
from
30c8f49
to
c1d6378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with Travis CI