Bug: Setting analyticsToken to empty string did not disable analytics in Ambar v2.0

[bakrowork]

Dear all,

Using ambar I see a lot of facebook, yandex, mixpanel, etc queries.
I think this open-source project should have option to opt-out from any tracking and etc.
At least have a remark about this in the README.md file.

My bigger problem is that this repo does not represents the docker image:
Please take a look at the frontend index.html file:
eg.: view-source:http://{your IP addr}/ or:

docker exec -t -i $(docker ps | grep ambar-frontend | grep -o '^\S*') /bin/bash
cd /usr/share/nginx/html
cat index.html

https://pastebin.com/TAGEtByh

This file does not equals to the one in the repository
https://github.com/RD17/ambar/blob/master/FrontEnd/src/index.html#L16

Please make a change!!

:(

[sochix]

Just set analyticsToken to empty string to disable it. It was described in our installation instructions. чт, 28 июня 2018 г. в 19:20, bakrowork <notifications@github.com>:

Dear all, Using ambar I see a lot of facebook, yandex, mixpanel, etc queries. I think this open-source project should have option to opt-out from any tracking and etc. At least have a remark about this in the README.md file. My bigger problem is that this repo does not represents the docker image: Please take a look at the frontend index.html file: eg.: view-source:http://{your IP addr}/ or: docker exec -t -i $(docker ps | grep ambar-frontend | grep -o '^\S*') /bin/bash cd /usr/share/nginx/html cat index.html https://pastebin.com/TAGEtByh This file does not equals to the one in the repository https://github.com/RD17/ambar/blob/master/FrontEnd/src/index.html#L16 Please make a change!! :( — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#171>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABd-YhQCE_MXxiDm7iW-rfghP47KT1tzks5uBQJHgaJpZM4U7sHw> .

-- Best regards, Ilya (http://sochix.ru) С уважением, Илья (http://sochix.ru)

[bakrowork]

If I am correct: you are referring to this: https://github.com/RD17/ambar/blob/master/Install.md as your installation instructions.

It does not mention the analyticsToken.

[sochix]

It was mentioned in our blog. Please, create a pull-request to Installation instruction and we'll add it

[bakrowork]

You mean this: https://blog.ambar.cloud/ambar-installation-step-by-step-guide-2/
which directs me to the same Install.md.

Editing the docker-compose.yml file and setting analyticsToken to an empty string makes no change:

Dont fool you the error codes, my adblocker block this sites.

[sochix]

Ok, can confirm that it's a bug

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bakrowork]

Should be fixed

[sochix]

Check v2.1.18, we completely removed analyticsToken from source code