Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rdflib.Graph.load() in a release version. #1356

Closed
edmondchuc opened this issue Jul 8, 2021 · 5 comments
Closed

Deprecate rdflib.Graph.load() in a release version. #1356

edmondchuc opened this issue Jul 8, 2021 · 5 comments
Assignees
@ashleysommer
Labels
fix-in-progress

Comments

@edmondchuc
Copy link
Contributor

Leave deprecation warning in for another major version.
@ashleysommer
Copy link
Contributor

The message currently says "will be removed in 6.0.0". Should we change the message, or remove it?
Also, graph.comment() graph.label() graph.preferredLabel() and graph.seq().
I've got to double check when we added the deprecation status to them.

@ashleysommer
Copy link
Contributor

4e41b8e
They were added after the 5.0.0 release.

@ashleysommer
Copy link
Contributor

I think at the time we'd intended to release a 5.1.0 with some minor fixes and these deprecations added, but it never happened because we ended up merging the python2-removal branch into master early.

@edmondchuc
Copy link
Contributor Author

Related issue #985

@juhoinkinen juhoinkinen mentioned this issue Nov 4, 2021
Merged
@ghost ghost added the fix-in-progress label Dec 27, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Resolved in #1527

@ghost ghost closed this as completed Dec 29, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashleysommer ashleysommer

Labels
fix-in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashleysommer @edmondchuc