Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@base performs strict checking for '#' #379

Closed
satra opened this issue Apr 2, 2014 · 2 comments
Closed

@base performs strict checking for '#' #379

satra opened this issue Apr 2, 2014 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@satra
Copy link
Contributor

satra commented Apr 2, 2014

i was getting this error:

...python2.7/site-packages/rdflib-4.1_dev-py2.7.egg/rdflib/plugins/parsers/notation3.pyc in join(here, there)
    109 
    110     assert(here.find("#") < 0), \
--> 111         "Base may not contain hash: '%s'" % here  # why must caller splitFrag?
    112 
    113     slashl = there.find('/')

AssertionError: Base may not contain hash: 'http://rohub.linkeddata.es/motifs_bundle_page-FGCS/index.html#'

according to the RDF 1.1 specs:

http://www.w3.org/TR/2014/REC-turtle-20140225/#grammar-production-base

@base and @Prefix share the same exact IRIREF pattern. is there a reason why this check exists?

@gromgull
Copy link
Member

gromgull commented Apr 3, 2014

We do not strictly implement RDF1.1 - BUT that being said, I guess this is a legacy line from cwm and noone knows why it is there :)

Do all unit tests still pass if you remove it?

If you remove it (and add a unit test for parsing files with # in the base!) and make a PR, Travis will test it for you.

@nicholsn
Copy link
Contributor

Ran into this issue as well and took a shot at what @gromgull suggested over at #407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants