Return null for empty or unavailable fields - addresses issue #492 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this approach is right, as if you don't have access to a field, you shouldn't know about it. |
|
@amitaibu That makes sense, but means you'll probably need a separate if() before the access check to specifically check for empty content. If that sounds alright, I'll create another PR for it. |
|
If the user has access and the content is empty - we can show the property. |
|
@krisgraham are you still working on this? May I provide direction? Thanks. |
|
I'm going to close this issue to unclutter the PR view. Feel free to re-open if you pick up this work again. Thanks for everything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.