This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
WIP: feat(Response): add file property to Response object to be able to serve files #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1992clement
changed the title
1992clement
force-pushed
the
file-support
branch
from
1f0f307
to
20d13b5
Compare
yannickroger
suggested changes
Apr 30, 2020
1992clement
force-pushed
the
file-support
branch
5 times, most recently
from
b347377
to
061cacb
Compare
RETFU
reviewed
May 3, 2020
1992clement
force-pushed
the
file-support
branch
5 times, most recently
from
3425481
to
a95b6cc
Compare
1992clement
changed the title
1992clement
changed the title
1992clement
force-pushed
the
file-support
branch
4 times, most recently
from
6ce792f
to
23b5271
Compare
RETFU
reviewed
May 5, 2020
RETFU
reviewed
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose is to be able to serve files with RREST.
This PR proposes to add a
Response::fileproperty. If this property is set, theRouter::getResponse()method will return aHttpFoundation\BinaryFileResponse, instead of a simpleHttpFoundation\Response.The detailled configuration of the BinaryFileResponse is expected to be done afterward, by the client. (headers, deleteFileAfterSend, etc...)