Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code and codeDescription in diagnostic #611

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

renkun-ken
Copy link
Member

According to the spec of Diagnostic, source should be something like the name of the provider of diagnostics service, and code be the number or name of a specific lint problem. Also, codeDescription can be used to provide a url to make it easier for user to learn more about the specific linter.

image

image

@renkun-ken renkun-ken requested a review from randy3k April 20, 2023 06:01
Copy link
Member

@randy3k randy3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@renkun-ken renkun-ken merged commit ec39b06 into REditorSupport:master Apr 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants