Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SD_ProtocolData.pm - remove register entry #1017

Merged
merged 7 commits into from
Sep 17, 2021
Merged

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Sep 16, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    -- register 0x2B are write on select attribute rfmode from sensor

  • What is the new behavior (if this is a feature change)?
    -- register 0x2B are NOT write on select attribute rfmode from sensor
    (documentation cc1101 writes -> "For test only. Do not write to this register.")

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    -- unnecessary writing of the register value is thus avoided

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1017 (0489284) into master (c2a3c14) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1017   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files         218      218           
  Lines       15282    15279    -3     
  Branches     2859     2859           
=======================================
- Hits         7648     7647    -1     
+ Misses       5995     5993    -2     
  Partials     1639     1639           
Flag Coverage Δ
fhem 50.24% <ø> (ø)
modules 50.04% <ø> (+<0.01%) ⬆️
perl 51.01% <ø> (+<0.01%) ⬆️
unittests 50.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
t/FHEM/00_SIGNALduino/01_SIGNALduino_Attr_rfmode.t 100.00% <ø> (ø)
t/SD_ProtocolData/01_verifyFSK.t 98.75% <ø> (-0.03%) ⬇️
local/lib/perl5/Test2/Util/HashBase.pm 48.43% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a3c14...0489284. Read the comment docs.

@HomeAutoUser HomeAutoUser merged commit b6a2fb6 into master Sep 17, 2021
@HomeAutoUser HomeAutoUser deleted the master_reg branch September 27, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants