WMBUS extension to dispatch messages #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
+ Coverage 70.92% 71.59% +0.66%
==========================================
Files 137 141 +4
Lines 10140 10184 +44
Branches 1584 1585 +1
==========================================
+ Hits 7192 7291 +99
+ Misses 1625 1569 -56
- Partials 1323 1324 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elektron-bbs
requested changes
Apr 23, 2024
elektron-bbs
approved these changes
Apr 24, 2024
sidey79
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(no DISPATCH from WMBUS Msg´s - Software extension for WMBUS #1247)
What is the current behavior?
(You can also link to an open issue here, if this describes the current behavior)
-- no dispatch
What is the new behavior (if this is a feature change)?
-- you can dispatch a WMBUS message to clientmodule
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
-- in order to receive messages yourself, the firmware must be adapted (later step)
-- new PR after discussion WMBUS extension to dispatch messages - old discussion #1248
-- codecov/patch isn'r required to pass for version Update.